a bug in function v_Assemble
Hi, I think I find a bug in function Nektar::MultiRegions::AssemblyMapCG::v_Assemble(const Array<OneD, const NekDouble> &loc, Array<OneD, NekDouble> &global) const, in file AssemblyMapCG.cpp. The fourth line of this function writes, "local = Array<OneD, NekDouble>(local.num_elements(),local.data());", which aims to make a copy of "loc" if "loc" and "global" have the same address. But this line makes a copy of "local", which hasn't been initialized yet. So this line should be substituted by "local = Array<OneD, NekDouble>(loc.num_elements(),loc.data());" Best regards, Ankang
Hi Ankang, Well-spotted and thank you for reporting it! I will apply the fix shortly which should then be included in our next patch release. Many thanks, Chris On 05/04/16 16:00, 高安康 wrote:
Hi,
I think I find a bug in function Nektar::MultiRegions::AssemblyMapCG::v_Assemble(const Array<OneD, const NekDouble> &loc, Array<OneD, NekDouble> &global) const, in file AssemblyMapCG.cpp.
The fourth line of this function writes, "local = Array<OneD, NekDouble>(local.num_elements(),local.data());", which aims to make a copy of "loc" if "loc" and "global" have the same address. But this line makes a copy of "local", which hasn't been initialized yet. So this line should be substituted by "local = Array<OneD, NekDouble>(loc.num_elements(),loc.data());"
Best regards,
Ankang
_______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
-- Chris Cantwell Imperial College London South Kensington Campus London SW7 2AZ Email: c.cantwell@imperial.ac.uk www.imperial.ac.uk/people/c.cantwell
Hi Ankang, Thanks for this bug report. Can I ask what function you were using where this became a problem since it would be good to know what solvers or utilities were being effected by this bug. Cheers, Spencer. On 6 Apr 2016, at 07:14, Chris Cantwell <c.cantwell@imperial.ac.uk<mailto:c.cantwell@imperial.ac.uk>> wrote: Hi Ankang, Well-spotted and thank you for reporting it! I will apply the fix shortly which should then be included in our next patch release. Many thanks, Chris On 05/04/16 16:00, 高安康 wrote: Hi, I think I find a bug in function Nektar::MultiRegions::AssemblyMapCG::v_Assemble(const Array<OneD, const NekDouble> &loc, Array<OneD, NekDouble> &global) const, in file AssemblyMapCG.cpp. The fourth line of this function writes, "local = Array<OneD, NekDouble>(local.num_elements(),local.data());", which aims to make a copy of "loc" if "loc" and "global" have the same address. But this line makes a copy of "local", which hasn't been initialized yet. So this line should be substituted by "local = Array<OneD, NekDouble>(loc.num_elements(),loc.data());" Best regards, Ankang _______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk<mailto:Nektar-users@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/nektar-users -- Chris Cantwell Imperial College London South Kensington Campus London SW7 2AZ Email: c.cantwell@imperial.ac.uk<mailto:c.cantwell@imperial.ac.uk> www.imperial.ac.uk/people/c.cantwell<http://www.imperial.ac.uk/people/c.cantwell> _______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk https://mailman.ic.ac.uk/mailman/listinfo/nektar-users Spencer Sherwin McLaren Racing/Royal Academy of Engineering Research Chair, Professor of Computational Fluid Mechanics, Department of Aeronautics, Imperial College London South Kensington Campus London SW7 2AZ s.sherwin@imperial.ac.uk<mailto:s.sherwin@imperial.ac.uk> +44 (0) 20 759 45052
participants (3)
-
Chris Cantwell
-
Sherwin, Spencer J
-
高安康