Regarding bug in integration of FieldConvert
******************* This email originates from outside Imperial. Do not click on links and attachments unless you recognise the sender. If you trust the sender, add them to your safe senders list https://spam.ic.ac.uk/SpamConsole/Senders.aspx to disable email stamping for this address. ******************* Hi, I want to report a bug in "mean" module of FieldConvert for the 2.5D case. There is an issue in the computation of integral which comes from the error in the computation of "Domain volume". I am taking a test case for channel flow "ChanFlow_3DH1D_FFT.xml." Here Lx = 1, Ly = 1, Lz = 1. So the volume should be 1. But the output depends upon the number of Fourier modes. Below is the output with Nz = 20. ------------------------------------------- Domain volume : 20 Integral (variable u) : 7.14583 Mean (variable u) : 0.357292 Integral (variable v) : 6.25 Mean (variable v) : 0.3125 Integral (variable w) : 5 Mean (variable w) : 0.25 Integral (variable p) : 10 Mean (variable p) : 0.5 ------------------------------------------- and this is one with Nz = 40. ------------------------------------------- Domain volume : 40 Integral (variable u) : 14.2292 Mean (variable u) : 0.355729 Integral (variable v) : 12.5 Mean (variable v) : 0.3125 Integral (variable w) : 10 Mean (variable w) : 0.25 Integral (variable p) : 20 Mean (variable p) : 0.5 --------------------------------------------- Now, by changing the number of Fourier modes the "Domain volume" and "integral" should not change. However, the value of "mean" is correct; thus it seems there is some normalization issue. Similarly, I can see a discrepancy in the "innerproduct" module as well. I have also attached the xml file for the reference. With regards Abhishek --------------------------------------------------------------------------------------- Abhishek Kumar Assistant Professor (Research) Centre for Fluid and Complex Systems Coventry University, Coventry CV15FB The United Kingdom Phone: +44 24 7765 9150 ---------------------------------------------------------------------------------------
Dear Abhishek, Thank you for flagging this issue. I have put a fix in a branch called fix/mean_3DH1D, which you can pull and test if you need this feature now. I will probably need some more time to make sure the change is reflected in other parts of the code, and will then proceed to merge into master. Kind regards, Andrea Cassinelli PhD candidate Department of Aeronautics Imperial College London London SW7 2AZ Mob.: +44 (0)7956957642 On 16 Jun 2020, at 23:52, Abhishek Kumar <abhishek.kir@gmail.com<mailto:abhishek.kir@gmail.com>> wrote: This email from abhishek.kir@gmail.com<mailto:abhishek.kir@gmail.com> originates from outside Imperial. Do not click on links and attachments unless you recognise the sender. If you trust the sender, add them to your safe senders list<https://spam.ic.ac.uk/SpamConsole/Senders.aspx> to disable email stamping for this address. Hi, I want to report a bug in "mean" module of FieldConvert for the 2.5D case. There is an issue in the computation of integral which comes from the error in the computation of "Domain volume". I am taking a test case for channel flow "ChanFlow_3DH1D_FFT.xml." Here Lx = 1, Ly = 1, Lz = 1. So the volume should be 1. But the output depends upon the number of Fourier modes. Below is the output with Nz = 20. ------------------------------------------- Domain volume : 20 Integral (variable u) : 7.14583 Mean (variable u) : 0.357292 Integral (variable v) : 6.25 Mean (variable v) : 0.3125 Integral (variable w) : 5 Mean (variable w) : 0.25 Integral (variable p) : 10 Mean (variable p) : 0.5 ------------------------------------------- and this is one with Nz = 40. ------------------------------------------- Domain volume : 40 Integral (variable u) : 14.2292 Mean (variable u) : 0.355729 Integral (variable v) : 12.5 Mean (variable v) : 0.3125 Integral (variable w) : 10 Mean (variable w) : 0.25 Integral (variable p) : 20 Mean (variable p) : 0.5 --------------------------------------------- Now, by changing the number of Fourier modes the "Domain volume" and "integral" should not change. However, the value of "mean" is correct; thus it seems there is some normalization issue. Similarly, I can see a discrepancy in the "innerproduct" module as well. I have also attached the xml file for the reference. With regards Abhishek --------------------------------------------------------------------------------------- Abhishek Kumar Assistant Professor (Research) Centre for Fluid and Complex Systems Coventry University, Coventry CV15FB The United Kingdom Phone: +44 24 7765 9150 --------------------------------------------------------------------------------------- <ChanFlow_3DH1D_FFT.xml>_______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk<mailto:Nektar-users@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
Hi Andrea, Thanks for the quick correction. I checked with the new branch and integral is fixed. However, there is still the same issue with the inner product. With regards Abhishek --------------------------------------------------------------------------------------- Abhishek Kumar Assistant Professor (Research) Centre for Fluid and Complex Systems Coventry University, Coventry CV15FB The United Kingdom --------------------------------------------------------------------------------------- On Wed, Jun 17, 2020 at 11:55 AM Cassinelli, Andrea < andrea.cassinelli15@imperial.ac.uk> wrote:
Dear Abhishek,
Thank you for flagging this issue. I have put a fix in a branch called fix/mean_3DH1D, which you can pull and test if you need this feature now. I will probably need some more time to make sure the change is reflected in other parts of the code, and will then proceed to merge into master.
Kind regards,
*Andrea Cassinelli* PhD candidate Department of Aeronautics Imperial College London London SW7 2AZ Mob.: +44 (0)7956957642
On 16 Jun 2020, at 23:52, Abhishek Kumar <abhishek.kir@gmail.com> wrote:
This email from abhishek.kir@gmail.com originates from outside Imperial. Do not click on links and attachments unless you recognise the sender. If you trust the sender, add them to your safe senders list <https://spam.ic.ac.uk/SpamConsole/Senders.aspx> to disable email stamping for this address.
Hi,
I want to report a bug in "mean" module of FieldConvert for the 2.5D case. There is an issue in the computation of integral which comes from the error in the computation of "Domain volume". I am taking a test case for channel flow "ChanFlow_3DH1D_FFT.xml."
Here Lx = 1, Ly = 1, Lz = 1. So the volume should be 1. But the output depends upon the number of Fourier modes.
Below is the output with Nz = 20.
------------------------------------------- Domain volume : 20 Integral (variable u) : 7.14583 Mean (variable u) : 0.357292 Integral (variable v) : 6.25 Mean (variable v) : 0.3125 Integral (variable w) : 5 Mean (variable w) : 0.25 Integral (variable p) : 10 Mean (variable p) : 0.5 -------------------------------------------
and this is one with Nz = 40.
------------------------------------------- Domain volume : 40 Integral (variable u) : 14.2292 Mean (variable u) : 0.355729 Integral (variable v) : 12.5 Mean (variable v) : 0.3125 Integral (variable w) : 10 Mean (variable w) : 0.25 Integral (variable p) : 20 Mean (variable p) : 0.5 ---------------------------------------------
Now, by changing the number of Fourier modes the "Domain volume" and "integral" should not change. However, the value of "mean" is correct; thus it seems there is some normalization issue. Similarly, I can see a discrepancy in the "innerproduct" module as well. I have also attached the xml file for the reference.
With regards Abhishek
--------------------------------------------------------------------------------------- Abhishek Kumar Assistant Professor (Research) Centre for Fluid and Complex Systems Coventry University, Coventry CV15FB The United Kingdom Phone: +44 24 7765 9150
--------------------------------------------------------------------------------------- <ChanFlow_3DH1D_FFT.xml>_______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
--
participants (2)
-
Abhishek Kumar
-
Cassinelli, Andrea