Hello, ProcessInterpPointDataToFld assigns the coordinates values instead of values of physical quantities when I using it to interpolate a fld from given points set in version 4.4.0 I find it is because line 131 in void Nektar::FieldUtils::ProcessInterpPointDataToFld::Process(po::variables_map & vm) is not right. 131 m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(j, i)); It should use an offset=outPts->GetDim() when assigning value to m_exp, like the follows m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(outPts->GetDim()+j, i)); Best wishes Ankang
Hi Ankang, Thanks for the bug report and potential fix! We just merged a branch that has some fixes for FieldConvert in -- not sure if we patched this but if not we can add it as a fix branch. Cheers, Dave
On 2 Jul 2017, at 10:41, Ankang Gao <gaoak@pku.edu.cn> wrote:
Hello,
ProcessInterpPointDataToFld assigns the coordinates values instead of values of physical quantities when I using it to interpolate a fld from given points set in version 4.4.0
I find it is because line 131 in void Nektar::FieldUtils::ProcessInterpPointDataToFld::Process(po::variables_map & vm) is not right. 131 m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(j, i));
It should use an offset=outPts->GetDim() when assigning value to m_exp, like the follows m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(outPts->GetDim()+j, i));
Best wishes
Ankang _______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
Hi Both, I suspect this might be fixed in a branch as I have been using this module a lot with no issues, but its in a private repository. We will look at merging it sooner rather than later now that we know someone needs it. Thanks Mike From: David Moxey<mailto:d.moxey@imperial.ac.uk> Sent: 03 July 2017 22:51 To: Ankang Gao<mailto:gaoak@pku.edu.cn> Cc: nektar-users<mailto:nektar-users@imperial.ac.uk> Subject: Re: [Nektar-users] a bug in ProcessInterpPointDataToFld Hi Ankang, Thanks for the bug report and potential fix! We just merged a branch that has some fixes for FieldConvert in -- not sure if we patched this but if not we can add it as a fix branch. Cheers, Dave
On 2 Jul 2017, at 10:41, Ankang Gao <gaoak@pku.edu.cn> wrote:
Hello,
ProcessInterpPointDataToFld assigns the coordinates values instead of values of physical quantities when I using it to interpolate a fld from given points set in version 4.4.0
I find it is because line 131 in void Nektar::FieldUtils::ProcessInterpPointDataToFld::Process(po::variables_map & vm) is not right. 131 m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(j, i));
It should use an offset=outPts->GetDim() when assigning value to m_exp, like the follows m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(outPts->GetDim()+j, i));
Best wishes
Ankang _______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
_______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
Hi, Having a quick look at the recent fix there does seem to be an offset of 3 in this bit of code so it may well work in the currently master. Cheers, Spencer. On 4 Jul 2017, at 09:16, Turner, Michael <m.turner14@imperial.ac.uk<mailto:m.turner14@imperial.ac.uk>> wrote: Hi Both, I suspect this might be fixed in a branch as I have been using this module a lot with no issues, but its in a private repository. We will look at merging it sooner rather than later now that we know someone needs it. Thanks Mike From: David Moxey<mailto:d.moxey@imperial.ac.uk> Sent: 03 July 2017 22:51 To: Ankang Gao<mailto:gaoak@pku.edu.cn> Cc: nektar-users<mailto:nektar-users@imperial.ac.uk> Subject: Re: [Nektar-users] a bug in ProcessInterpPointDataToFld Hi Ankang, Thanks for the bug report and potential fix! We just merged a branch that has some fixes for FieldConvert in -- not sure if we patched this but if not we can add it as a fix branch. Cheers, Dave
On 2 Jul 2017, at 10:41, Ankang Gao <gaoak@pku.edu.cn<mailto:gaoak@pku.edu.cn>> wrote:
Hello,
ProcessInterpPointDataToFld assigns the coordinates values instead of values of physical quantities when I using it to interpolate a fld from given points set in version 4.4.0
I find it is because line 131 in void Nektar::FieldUtils::ProcessInterpPointDataToFld::Process(po::variables_map & vm) is not right. 131 m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(j, i));
It should use an offset=outPts->GetDim() when assigning value to m_exp, like the follows m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(outPts->GetDim()+j, i));
Best wishes
Ankang _______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk<mailto:Nektar-users@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
_______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk<mailto:Nektar-users@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/nektar-users _______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk<mailto:Nektar-users@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/nektar-users Spencer Sherwin McLaren Racing/Royal Academy of Engineering Research Chair, Professor of Computational Fluid Mechanics, Department of Aeronautics, Imperial College London South Kensington Campus London SW7 2AZ s.sherwin@imperial.ac.uk<mailto:s.sherwin@imperial.ac.uk> +44 (0) 20 759 45052
Hi, this was fixed in Nektar++ version 4.4.1 (MR ! 754). Cheers, Kilian Am Dienstag, 4. Juli 2017, 20:21:35 CEST schrieb Sherwin, Spencer J:
Hi,
Having a quick look at the recent fix there does seem to be an offset of 3 in this bit of code so it may well work in the currently master.
Cheers, Spencer.
On 4 Jul 2017, at 09:16, Turner, Michael <m.turner14@imperial.ac.uk<mailto:m.turner14@imperial.ac.uk>> wrote:
Hi Both,
I suspect this might be fixed in a branch as I have been using this module a lot with no issues, but its in a private repository. We will look at merging it sooner rather than later now that we know someone needs it.
Thanks Mike
From: David Moxey<mailto:d.moxey@imperial.ac.uk> Sent: 03 July 2017 22:51 To: Ankang Gao<mailto:gaoak@pku.edu.cn> Cc: nektar-users<mailto:nektar-users@imperial.ac.uk> Subject: Re: [Nektar-users] a bug in ProcessInterpPointDataToFld
Hi Ankang,
Thanks for the bug report and potential fix! We just merged a branch that has some fixes for FieldConvert in -- not sure if we patched this but if not we can add it as a fix branch.
Cheers,
Dave
On 2 Jul 2017, at 10:41, Ankang Gao <gaoak@pku.edu.cn<mailto:gaoak@pku.edu.cn>> wrote:
Hello,
ProcessInterpPointDataToFld assigns the coordinates values instead of values of physical quantities when I using it to interpolate a fld from given points set in version 4.4.0
I find it is because line 131 in void Nektar::FieldUtils::ProcessInterpPointDataToFld::Process(po::variables_ma p & vm) is not right. 131 m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(j, i));
It should use an offset=outPts->GetDim() when assigning value to m_exp, like the follows m_f->m_exp[j]->SetPhys(i, outPts->GetPointVal(outPts->GetDim()+j, i));
Best wishes
Ankang _______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk<mailto:Nektar-users@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
_______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk<mailto:Nektar-users@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/nektar-users _______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk<mailto:Nektar-users@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
Spencer Sherwin McLaren Racing/Royal Academy of Engineering Research Chair, Professor of Computational Fluid Mechanics, Department of Aeronautics, Imperial College London South Kensington Campus London SW7 2AZ
s.sherwin@imperial.ac.uk<mailto:s.sherwin@imperial.ac.uk> +44 (0) 20 759 45052
-- Kilian Lackhove, M.Sc. Fachgebiet für Energie- und Kraftwerkstechnik L1|08 114 Technische Universität Darmstadt Jovanka-Bontschits-Straße 2 D-64287 Darmstadt Germany Tel.: +49 6151 16 - 28915 Fax: +49 6151 16 - 6555 e-mail: lackhove@ekt.tu-darmstadt.de
participants (5)
-
Ankang Gao
-
David Moxey
-
Kilian Lackhove
-
Sherwin, Spencer J
-
Turner, Michael