Hi, I use the same Lagrange interpolation polynomial as Nektar::LibUtilities::GaussPoints::LagrangePoly or Nektar::LibUtilities::PolyEPoints::LagrangePoly. The Polylib.cpp file I modified is attached, and the differences between this file and the original one are shown in another attachment 'difference.txt' which is obtained by command "diff" in linux OS. After this modification, the main numerical error of funtion PhysEvaluate is contributed by NewtonIterationForLocCoord, which is 2.e-6 maximum in my tests with 12 points each direction in a quad geometry. I'm glad to see that my report is of use to improve nektar++. In my opinion, Nektar++ is a wonderful code, and it has become the main numerical tool in my research. I am looking forward to nektar++ getting more and more powerful. Ankang -----原始邮件----- 发件人:"Sherwin, Spencer J" <s.sherwin@imperial.ac.uk> 发送时间:2017-04-21 22:51:00 (星期五) 收件人: "Ankang Gao" <gaoak@pku.edu.cn> 抄送: nektar-users <nektar-users@imperial.ac.uk> 主题: Re: [Nektar-users] 2 bugs and 1 question Hi Ankang, Sorry it has taken rather long to get back to you. Thanks for your clear explanation which I think is very interesting and we should do something about this. Do you have a modified polylib.cpp we can include. I am not sure if the papers that Dave forwarded offer a more robust way of evaluating the lagging polynomial near the quadrature points since that is the only other modification I can think we might consider. I am cc’ing Mike so he can also perhaps comments on this point. Cheers, Spencer.
On 14 Apr 2017, at 13:06, Ankang Gao <gaoak@pku.edu.cn> wrote:
Hellow,
I have found two bugs in the codes, and I listed them in the attachment.
I have a question about why the backward differentiation formula starts after m_pressureCalls>2, in function void Nektar::Extrapolate::AccelerationBDF(Array< OneD, Array< OneD, NekDouble > > & array). Since when m_pressureCalls=2, we can already get a first order accuracy result.
thanks
Ankang <reportbug_question.pdf>_______________________________________________ Nektar-users mailing list Nektar-users@imperial.ac.uk https://mailman.ic.ac.uk/mailman/listinfo/nektar-users
Spencer Sherwin McLaren Racing/Royal Academy of Engineering Research Chair, Professor of Computational Fluid Mechanics, Department of Aeronautics, Imperial College London South Kensington Campus London SW7 2AZ s.sherwin@imperial.ac.uk +44 (0) 20 759 45052