Hi,
Chris, Dave and I have been exploring ways of improving our master merging process. We are going to test a peer review process where we send out requests to a couple of users to look over the code of a given request.
We are going use the gitlab page to keep a record of this process so it is important to put all comments in the “Discussion” tab at the bottom of the merge request.
Could I therefore ask you to check:
1) The branch has a recent merge with master
2) The branch passes buildbot
3) The branch meets the coding standard
4) To best of your knowledge, the functionality is not duplicated in the rest of the code and hopefully implemented in a sensible manner
If the author needs to update the code at any of these stages then a comment should be added to the discussion tab, the author will then get a notification (as will the assignees and reviewers). When the author has responded to the points raised by the reviewer, he/she will also put a comment in the discussion tab and again all participants will be notified.
For individual comment on lines of codes please note there is a way of adding a local comment by clicking on the “+” sign under the changes tab.
When the reviewing process is finished the reviewer should put an entry into the discussion that states the review is complete. The assigned “editor” (i.e. Dave, Chris or I) will then get a notification that it is complete and hopefully follow up quickly.
Many thanks,
Spencer.
Spencer Sherwin
McLaren Racing/Royal Academy of Engineering Research Chair,
Professor of Computational Fluid Mechanics,
Department of Aeronautics,
Imperial College London
South Kensington Campus
London SW7 2AZ
s.sherwin(a)imperial.ac.uk
+44 (0) 20 759 45052