PyOP2 branch with logging support
Hi Lawrence, I pulled your PyOP2 branch with logging support and updated by firedrake modules+dependencies (ffc, ufl, coffee, fiat - all master), and I get the following when I try to run firedrake-clean: eikemueller@Eikes-MacBook-Pro $ ./scripts/firedrake-clean Traceback (most recent call last): File "./scripts/firedrake-clean", line 3, in <module> from firedrake.ffc_interface import clear_cache, FFCKernel File "/Users/eikemueller/PostDocBath/EllipticSolvers/firedrake/firedrake/__init__.py", line 31, in <module> from pyop2.logger import set_log_level, info_red, info_green, info_blue, log # noqa File "/Users/eikemueller/PostDocBath/EllipticSolvers/PyOP2/pyop2/__init__.py", line 13, in <module> from op2 import * File "/Users/eikemueller/PostDocBath/EllipticSolvers/PyOP2/pyop2/op2.py", line 39, in <module> import base File "/Users/eikemueller/PostDocBath/EllipticSolvers/PyOP2/pyop2/base.py", line 60, in <module> from coffee.visitors import FindInstances, EstimateFlops ImportError: No module named visitors To me it looks like PyOP2 tries to import a non-existant coffee module, but that’s weird, since there is a subdirectory coffee/visitors in my COFFEE installation, and the __init__.py contains: eikemueller@Eikes-MacBook-Pro $ cat __init__.py from __future__ import absolute_import from coffee.visitors.utilities import * from coffee.visitors.inspectors import * and FindInstances is defined in inspectors.py eikemueller@Eikes-MacBook-Pro $ grep FindInstances *py inspectors.py: "SymbolDeclarations", "FindInstances"] inspectors.py:class FindInstances(Visitor): inspectors.py: super(FindInstances, self).__init__() Thanks, Eike -- Dr Eike Hermann Mueller Lecturer in Scientific Computing Department of Mathematical Sciences University of Bath Bath BA2 7AY, United Kingdom +44 1225 38 6470 e.mueller@bath.ac.uk<mailto:e.mueller@bath.ac.uk> http://people.bath.ac.uk/em459/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 30/09/15 10:02, Eike Mueller wrote:
Hi Lawrence,
I pulled your PyOP2 branch with logging support and updated by firedrake modules+dependencies (ffc, ufl, coffee, fiat - all master), and I get the following when I try to run firedrake-clean:
eikemueller@Eikes-MacBook-Pro $ ./scripts/firedrake-clean Traceback (most recent call last): File "./scripts/firedrake-clean", line 3, in <module> from firedrake.ffc_interface import clear_cache, FFCKernel File "/Users/eikemueller/PostDocBath/EllipticSolvers/firedrake/firedrake/__init__.py", line 31, in <module> from pyop2.logger import set_log_level, info_red, info_green, info_blue, log # noqa File "/Users/eikemueller/PostDocBath/EllipticSolvers/PyOP2/pyop2/__init__.py", line 13, in <module> from op2 import * File "/Users/eikemueller/PostDocBath/EllipticSolvers/PyOP2/pyop2/op2.py", line 39, in <module> import base File "/Users/eikemueller/PostDocBath/EllipticSolvers/PyOP2/pyop2/base.py", line 60, in <module> from coffee.visitors import FindInstances, EstimateFlops ImportError: No module named visitors
Can you do: git clean -fdx In the PyOP2 directory and then make Lawrence -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWC6dVAAoJECOc1kQ8PEYva3wIAIgYRKdE/ue6c5zLHlfhMs/q hruvEaRHUEvfWzVxPtNrsA7jot6kotyDV/+qsRXtQWsWWclNrY2XB1mIzc5w17dc bFoTGi67wXFfkIXmH4uFfMh+fiXZ53wCRR/SjBZLczNwyZ59h/gR+fGOoeQuT8bk EPM3MoamKlMbhMoJrbUylc/1hP5YwKv2raafSK4aseK+Fhk+0/lQh/6bBRdndM84 GpsjVwu2VWrzTcEdgTFECD6sO/bw/QI+L3WOqW7fNf/gL70qedEJPsvR2NxamYWR QZVz1ahbbd2XrNINy/l9CxUei6jrGrytWo/4Gzftt9aA4IajTKWiLtMhcLCX2qQ= =kkaY -----END PGP SIGNATURE-----
Hi Lawrence, thanks, I managed to fix it. It turns out that in the past I had installed coffee with ‘python setup.py build’, and my python path was still pointing to this directory, i.e. when I updated coffee, it was still using the old version. I now just set the python path to the COFFEE directory, is there any point in running ‘python setup.py build’ anyways, or does it just copy the source files to build? Thanks, Eike -- Dr Eike Hermann Mueller Lecturer in Scientific Computing Department of Mathematical Sciences University of Bath Bath BA2 7AY, United Kingdom +44 1225 38 6470 e.mueller@bath.ac.uk<mailto:e.mueller@bath.ac.uk> http://people.bath.ac.uk/em459/ On 30 Sep 2015, at 11:11, Lawrence Mitchell <lawrence.mitchell@imperial.ac.uk<mailto:lawrence.mitchell@imperial.ac.uk>> wrote: git clean -fdx
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 30/09/15 10:38, Eike Mueller wrote:
Hi Lawrence,
thanks, I managed to fix it. It turns out that in the past I had installed coffee with ‘python setup.py build’, and my python path was still pointing to this directory, i.e. when I updated coffee, it was still using the old version. I now just set the python path to the COFFEE directory, is there any point in running ‘python setup.py build’ anyways, or does it just copy the source files to build?
In the case of pure python modules (like COFFEE) all it does is copy the source files. Lawrence -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWC66OAAoJECOc1kQ8PEYvhu4H/RGQRIG8QckfZ6DwFVY2yXeB hIChUTDMhN3DkZZ38sHG20aGjfAxd2N2IzkZfATLeVlZ6sV0M3+Uoz89mpIHFboZ DVUAgRVHpKPl3C59VDu8Lx/pEcGjBfMTel28byoTFbaOkxU0+r5+fXaNtDh1RrCK ChiDuQRfPYGBgzgRBGUggLer7ahnGzbrCdMOI15qDbdOFAc1NcVhX/iW9bJXFBVv yOKxpz0dUEdIMuPGgywb7uTY8BGeiEg6T9RG3zSMHPxtDRXPGBdNaPbzJiup9xU7 BeRza0SLZpvFSjbYmnZSZspmwduhwG24VF5kCUNGb9eDM1V+sPl4OhBzNPjxLNI= =AyiF -----END PGP SIGNATURE-----
Hi Lawrence, did the changes in columnwise_kernels ever get merged into the trunk? They don’t seem to be in the performance-logging, since I get the error below, which implies that the following commit has not been included: https://github.com/OP2/PyOP2/commit/82ed49be4bff6d015e79d676573c11acd016c763 Traceback (most recent call last): File "driver.py", line 652, in <module> main(parameter_filename) File "driver.py", line 601, in main u_matrixfree,p_matrixfree,b_matrixfree = solve_matrixfree(functionspaces,dt,all_param,expression) File "driver.py", line 415, in solve_matrixfree dt,all_param) File "driver.py", line 301, in matrixfree_solver_setup omega_N) File "/Users/eikemueller/PostDocBath/EllipticSolvers/Firedrake_workspace/firedrake-helmholtzsolver/source/pressuresolver/hierarchy.py", line 30, in __init__ self._data = [Type(*x,**kwargs) for x in arglist] File "/Users/eikemueller/PostDocBath/EllipticSolvers/Firedrake_workspace/firedrake-helmholtzsolver/source/pressuresolver/operators.py", line 188, in __init__ vertical_bcs=True) File "/Users/eikemueller/PostDocBath/EllipticSolvers/Firedrake_workspace/firedrake-helmholtzsolver/source/bandedmatrix/bandedmatrix.py", line 215, in assemble_ufl_form self._assemble_lma(lma,vertical_bcs) File "/Users/eikemueller/PostDocBath/EllipticSolvers/Firedrake_workspace/firedrake-helmholtzsolver/source/bandedmatrix/bandedmatrix.py", line 256, in _assemble_lma kernel = op2.Kernel(kernel_code % param_dict,'assemble_lma',cpp=True) File "/Users/eikemueller/PostDocBath/EllipticSolvers/PyOP2/pyop2/backends.py", line 118, in __call__ return t(*args, **kwargs) File "/Users/eikemueller/PostDocBath/EllipticSolvers/PyOP2/pyop2/caching.py", line 182, in __new__ key = cls._cache_key(*args, **kwargs) TypeError: _cache_key() got an unexpected keyword argument ‘cpp' Cheers, Eike -- Dr Eike Hermann Mueller Lecturer in Scientific Computing Department of Mathematical Sciences University of Bath Bath BA2 7AY, United Kingdom +44 1225 38 6470 e.mueller@bath.ac.uk<mailto:e.mueller@bath.ac.uk> http://people.bath.ac.uk/em459/ On 30 Sep 2015, at 11:42, Lawrence Mitchell <lawrence.mitchell@imperial.ac.uk<mailto:lawrence.mitchell@imperial.ac.uk>> wrote: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 30/09/15 10:38, Eike Mueller wrote: Hi Lawrence, thanks, I managed to fix it. It turns out that in the past I had installed coffee with ‘python setup.py build’, and my python path was still pointing to this directory, i.e. when I updated coffee, it was still using the old version. I now just set the python path to the COFFEE directory, is there any point in running ‘python setup.py build’ anyways, or does it just copy the source files to build? In the case of pure python modules (like COFFEE) all it does is copy the source files. Lawrence -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWC66OAAoJECOc1kQ8PEYvhu4H/RGQRIG8QckfZ6DwFVY2yXeB hIChUTDMhN3DkZZ38sHG20aGjfAxd2N2IzkZfATLeVlZ6sV0M3+Uoz89mpIHFboZ DVUAgRVHpKPl3C59VDu8Lx/pEcGjBfMTel28byoTFbaOkxU0+r5+fXaNtDh1RrCK ChiDuQRfPYGBgzgRBGUggLer7ahnGzbrCdMOI15qDbdOFAc1NcVhX/iW9bJXFBVv yOKxpz0dUEdIMuPGgywb7uTY8BGeiEg6T9RG3zSMHPxtDRXPGBdNaPbzJiup9xU7 BeRza0SLZpvFSjbYmnZSZspmwduhwG24VF5kCUNGb9eDM1V+sPl4OhBzNPjxLNI= =AyiF -----END PGP SIGNATURE-----
participants (2)
-
Eike Mueller
-
Lawrence Mitchell