Re: [firedrake] PyOP2 pull request #465
Aaargh! Damn. Can you report this as a bug and I'll try to find time to get onto it. David On Tue, 13 Oct 2015 at 15:35 Eike Mueller <E.Mueller@bath.ac.uk> wrote:
Dear all,
actually, on my mac, I need to add the flag ‘-Wa,-q’ to get the code to compile, otherwise I get errors of this type:
[…] /var/folders/yy/9wfgymp14_1b9zt2x0ycs64m0000gn/T//ccIqsgIb.s:9:no such instruction: `vxorpd %xmm5, %xmm5,%xmm5' /var/folders/yy/9wfgymp14_1b9zt2x0ycs64m0000gn/T//ccIqsgIb.s:12:no such instruction: `vmovsd LC1(%rip), %xmm2’ […]
Also, I need to be able to specify additional libraries and their paths (I need LAPACK and BLAS). What I did in the past is this:
https://github.com/OP2/PyOP2/commit/865b66ea4c399a9de0949388103a964cb89b2b91
(that’s in the columnwise kernel branch, and I think those changes never made it into master).
Looking at the kernel constructor in base.py, I think at the moment I can only pass include directories and headers, but I can’t see how I can pass linker options.
def __init__(self, code, name, opts={}, include_dirs=[], headers=[], user_code="", cpp=False):
I can go ahead and add functionality for specifying library paths in a branch and create a pull request, but maybe you already solved this differently and I just can’t figure out how to pass in the library paths correctly?
Thanks,
Eike
On 13 Oct 2015, at 09:38, Eike Mueller <E.Mueller@bath.ac.uk> wrote:
Ok, that's great, thanks a lot! I will give it a go.
Eike
PS: I will be in London next week, so I arranged with Lawrence to meet on Wednesday (21 Oct). I'll probably come down the day before but will also try arrange some placement visits for the Tuesday afternoon.
------------------------------ *From:* firedrake-bounces@imperial.ac.uk <firedrake-bounces@imperial.ac.uk> on behalf of David Ham <David.Ham@imperial.ac.uk> *Sent:* 13 October 2015 09:31 *To:* firedrake *Subject:* Re: [firedrake] PyOP2 pull request #465
Hi Eike,
Lawrence is on holiday so I'm taking a rash executive decision to merge that pull request. If it breaks Firedrake (unlikely) I'll have to pull it again.
Regards,
David
On Mon, 12 Oct 2015 at 17:54 Eike Mueller <E.Mueller@bath.ac.uk> wrote:
Dear firedrake,
what's the status of PyOP2 pull request #465 ( https://github.com/OP2/PyOP2/pull/465) <https://github.com/OP2/PyOP2/pull/465>? Is this about to be merged?
I've got some changes in my code that depend on it (both in the geometric multigrid code and the performance logging branch), so would be great to have support for C++ kernels in the master.
Thanks,
Eike
_______________________________________________ firedrake mailing list firedrake@imperial.ac.uk https://mailman.ic.ac.uk/mailman/listinfo/firedrake
Hi David, thanks, I just raised an issue on github. Once I manually hack in in support for user-defined -l and -L flags for the kernel compilation the multigrid code runs again. That’s good news! However, I noticed that this problem is already addressed in #415 which includes support for user-specified linker options. I guess I can just set PYOP2_LDFLAGS=<my_libraries> once this has been merged. Cheers, Eike On 13 Oct 2015, at 18:20, David Ham <David.Ham@imperial.ac.uk<mailto:David.Ham@imperial.ac.uk>> wrote: Aaargh! Damn. Can you report this as a bug and I'll try to find time to get onto it. David On Tue, 13 Oct 2015 at 15:35 Eike Mueller <E.Mueller@bath.ac.uk<mailto:E.Mueller@bath.ac.uk>> wrote: Dear all, actually, on my mac, I need to add the flag ‘-Wa,-q’ to get the code to compile, otherwise I get errors of this type: […] /var/folders/yy/9wfgymp14_1b9zt2x0ycs64m0000gn/T//ccIqsgIb.s:9:no such instruction: `vxorpd %xmm5, %xmm5,%xmm5' /var/folders/yy/9wfgymp14_1b9zt2x0ycs64m0000gn/T//ccIqsgIb.s:12:no such instruction: `vmovsd LC1(%rip), %xmm2’ […] Also, I need to be able to specify additional libraries and their paths (I need LAPACK and BLAS). What I did in the past is this: https://github.com/OP2/PyOP2/commit/865b66ea4c399a9de0949388103a964cb89b2b91 (that’s in the columnwise kernel branch, and I think those changes never made it into master). Looking at the kernel constructor in base.py, I think at the moment I can only pass include directories and headers, but I can’t see how I can pass linker options. def __init__(self, code, name, opts={}, include_dirs=[], headers=[], user_code="", cpp=False): I can go ahead and add functionality for specifying library paths in a branch and create a pull request, but maybe you already solved this differently and I just can’t figure out how to pass in the library paths correctly? Thanks, Eike On 13 Oct 2015, at 09:38, Eike Mueller <E.Mueller@bath.ac.uk<mailto:E.Mueller@bath.ac.uk>> wrote: Ok, that's great, thanks a lot! I will give it a go. Eike PS: I will be in London next week, so I arranged with Lawrence to meet on Wednesday (21 Oct). I'll probably come down the day before but will also try arrange some placement visits for the Tuesday afternoon. ________________________________ From: firedrake-bounces@imperial.ac.uk<mailto:firedrake-bounces@imperial.ac.uk> <firedrake-bounces@imperial.ac.uk<mailto:firedrake-bounces@imperial.ac.uk>> on behalf of David Ham <David.Ham@imperial.ac.uk<mailto:David.Ham@imperial.ac.uk>> Sent: 13 October 2015 09:31 To: firedrake Subject: Re: [firedrake] PyOP2 pull request #465 Hi Eike, Lawrence is on holiday so I'm taking a rash executive decision to merge that pull request. If it breaks Firedrake (unlikely) I'll have to pull it again. Regards, David On Mon, 12 Oct 2015 at 17:54 Eike Mueller <E.Mueller@bath.ac.uk<mailto:E.Mueller@bath.ac.uk>> wrote: Dear firedrake, what's the status of PyOP2 pull request #465 (https://github.com/OP2/PyOP2/pull/465)<https://github.com/OP2/PyOP2/pull/465>? Is this about to be merged? I've got some changes in my code that depend on it (both in the geometric multigrid code and the performance logging branch), so would be great to have support for C++ kernels in the master. Thanks, Eike _______________________________________________ firedrake mailing list firedrake@imperial.ac.uk<mailto:firedrake@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/firedrake _______________________________________________ firedrake mailing list firedrake@imperial.ac.uk<mailto:firedrake@imperial.ac.uk> https://mailman.ic.ac.uk/mailman/listinfo/firedrake
participants (2)
-
David Ham
-
Eike Mueller